fix(inbox): don't show onboarding while data is still loading#2392
Merged
Conversation
The onboarding pane was latching on first render because both hasReports and hasSignalSources read false before the queries settled, so users with a configured inbox briefly saw the setup view and the latch stuck for the visit. Gate entry on the same prerequisites the sources dialog uses (integrations + signal source configs loaded, reports query not loading, no error), and move the latch into a useEffect.
Twixes
force-pushed
the
fix-inbox-onboarding-loading-race
branch
from
dc91673 to
048b021
Compare
Contributor
|
Reviews (1): Last reviewed commit: "fix(inbox): don't show onboarding while ..." | Re-trigger Greptile |
andrewm4894
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In production, users with a configured inbox (lots of reports, sources enabled) were seeing the "Set up self-driving for your product" onboarding pane.
On first paint the queries haven't settled, so
hasReportsandhasSignalSourcesboth read false. The previous code latched onboarding on that derived value via a ref mutated during render - so the first paint flipped the latch, and the latch is sticky for the visit.Fix
Move the latch from a ref-mutated-in-render to a
useEffect-drivenuseState. The setter is a no-op once true (React bails out), so no loops. Tested by running this.